Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses failures in DatabasInplaceUpgrade by adding backup/restore support for the stellar-misc.db SQLite database, while keeping compatibility with older peers that predate the main/misc DB split.
Changes:
- Add
stellar-misc.dbbackup creation during peer data dumps (optional when the misc DB does not exist). - Add optional restore of the misc DB when fetching a DB backup from another peer.
- Introduce new config constants/URLs for misc DB paths and transfer locations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/FSLibrary/StellarKubeSpecs.fs |
Adds an optional misc DB restore step during DB fetch from a peer. |
src/FSLibrary/StellarDataDump.fs |
Adds misc DB backup generation, guarded by existence checks. |
src/FSLibrary/StellarCoreCfg.fs |
Adds misc DB path/backup path/URL constants used by backup/restore flows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marta-lokhova
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
DatabasInplaceUpgradefailure we're now running into.