Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the Soroban config_settings transformation pipeline to include additional protocol config fields (P23) and CAP-77 “frozen ledger keys” fields (P26), ensuring they are emitted in both JSON and Parquet outputs.
Changes:
- Added new P23 and P26 fields to the
ConfigSettingOutput/ConfigSettingOutputParquetschemas. - Populated the new fields in
TransformConfigSettingand mapped them throughToParquet(). - Updated config-setting transform tests to include new P23 config setting IDs.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/transform/schema.go | Adds new JSON fields to ConfigSettingOutput for P23/P26 config settings. |
| internal/transform/schema_parquet.go | Adds matching Parquet schema fields for P23/P26 config settings. |
| internal/transform/parquet_converter.go | Maps the new config-setting fields into the Parquet output struct. |
| internal/transform/config_setting.go | Extracts new P23/P26 values and introduces serializers for CAP-77 fields. |
| internal/transform/config_setting_test.go | Adds test fixtures/expectations for the new P23 config setting IDs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
chowbao
reviewed
Apr 6, 2026
chowbao
reviewed
Apr 6, 2026
chowbao
reviewed
Apr 6, 2026
Comment on lines
+137
to
+138
| freezeBypassTxsDelta, _ := configSetting.GetFreezeBypassTxsDelta() | ||
| freezeBypassTxsDeltaJSON := serializeFreezeBypassTxsDelta(freezeBypassTxsDelta) |
Contributor
There was a problem hiding this comment.
Same recommendation as https://github.com/stellar/stellar-etl/pull/401/changes#r3041684008
Flatten instead of making it a map
chowbao
reviewed
Apr 6, 2026
chowbao
reviewed
Apr 6, 2026
6 tasks
chowbao
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
Thoroughness
Release planning
semver, and I've changed the name of the BRANCH to major/_ , minor/_ or patch/* .
What
[TODO: Short statement about what is changing.]
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]