🗓️ Add 2019 meeting notes - #2782
Open
JFWooten4 wants to merge 2 commits into
Open
Conversation
Co-authored-by: Codex Web <noreply@openai.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ten 2019 meeting archives to the meetings collection, including historical protocol discussions and one Meridian recording.
Changes:
- Adds 2019 meeting summaries and proposal tags.
- Registers Johnny Goodnow as an author.
- Updates generated meeting, author, tag, and pagination routes.
Recommendation: NEEDS-CHANGES — Correct proposal formatting/titles, missing CAP-6 tagging, and inaccurate metadata.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
routes.txt |
Adds generated meeting and taxonomy routes. |
meetings/authors.yml |
Adds the meeting-note author profile. |
meetings/2019-01-24.mdx |
Archives January protocol discussions. |
meetings/2019-03-07.mdx |
Summarizes protocol priorities and proposals. |
meetings/2019-03-14.mdx |
Documents trustline and fee discussions. |
meetings/2019-03-21.mdx |
Covers authorization, fees, and order books. |
meetings/2019-03-28.mdx |
Records CAP and multisig discussions. |
meetings/2019-04-04.mdx |
Documents mergeable-trustline proposals. |
meetings/2019-06-13.mdx |
Summarizes precondition and fee-bump work. |
meetings/2019-06-27.mdx |
Details payment and precondition proposals. |
meetings/2019-07-25.mdx |
Records several CAP decisions. |
meetings/2019-11-04.mdx |
Embeds and summarizes a Meridian address. |
Suppressed comments (7)
meetings/2019-01-24.mdx:22
- The proposal names in this page are displayed with zero-padding (for example,
CAP-0005), contrary to the repository rule inCONTRIBUTING.md:85requiringCAP-5/SEP-13in prose while retaining padded canonical filenames in URLs. Please update all displayed CAP/SEP references on this page; the affected text includes lines 22–31, 45–48, 54, 59, and 63–64.
- [CAP-0005](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0005.md) & [CAP-0006](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0006.md) - moving to approval.
meetings/2019-03-07.mdx:75
- This labels CAP-15 as “Bump Fee Transactions,” but the linked canonical proposal's title is “Fee-Bump Transactions.” Use the canonical title consistently so readers can identify the proposal unambiguously.
- [CAP-0015](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0015.md) - Bump Fee Transactions (OrbitLens)
meetings/2019-03-28.mdx:25
- “Bump Fee Extension” is not the linked CAP-15 title; the canonical proposal is “Fee-Bump Transactions.” Use the canonical title consistently so readers can identify the proposal unambiguously.
- [CAP-0015](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0015.md) (Bump Fee Extension): Modified to utilize [CAP-0019](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0019.md). Goal is to bring it to a vote, or enumerate what is needed to make it pass.
meetings/2019-03-14.mdx:34
- These descriptions are not the canonical proposal titles. The linked specifications call SEP-17 “Issuer account funding protocol (CAP-13 Based)” and SEP-16 “Account Transfer Permissionless Payment Protocol (atp3).” Please use those titles so the historical notes identify the proposals accurately.
- [SEP-0017](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0017.md): Deposit & transfer of assets using [CAP-0013](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0013.md)
- [SEP-0016](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0016.md): Deposit & transfer of assets using deterministic accounts
meetings/2019-06-27.mdx:22
- The canonical CAP-23 title is “Two-Part Payments with ClaimableBalanceEntry,” not “Two-Part Payments with BalanceEntry.” Because the body also uses names from an earlier draft, clarify the historical terminology while giving the linked proposal its canonical title.
- [CAP-0023](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0023.md) - _Two-Part Payments with BalanceEntry_
meetings/2019-07-25.mdx:18
- “Path Payment w/Fixed Amount” is not CAP-24's canonical title. The linked proposal is titled “Make PathPayment Symmetrical”; use that title here.
- [CAP-0024](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0024.md) - Path Payment w/Fixed Amount
meetings/2019-07-25.mdx:24
- The CAP-25 label is not its canonical title: the linked proposal is “Remove Bucket Shadowing,” not “Shadow Bucket Removal.” Use the canonical proposal titles in this summary.
- [CAP-0021](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0021.md), [CAP-0022](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0022.md), [CAP-0025](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0025.md) - Preconditions, Invalid Transaction Effects, Shadow Bucket Removal
đź’ˇ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| ### Final Comment Period - Acceptance | ||
|
|
||
| - [CAP-0017](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0017.md) - Update `LastModifiedLedgerSeq` If and Only If LedgerEntry Is Modified (Jonathan Jove) |
|
|
||
| ### Announcements | ||
|
|
||
| - Jon made additional changes to [CAP-0018](https://github.com/stellar/stellar-protocol/pull/263); with no further comments, it will move out of FCP next week. |
|
|
||
| ### Announcements | ||
|
|
||
| - [CAP-0016](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0016.md) rejected in favor of [CAP-0018](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0018.md) (now Accepted). CAP-0016 will only be revived if CAP-0018 encounters implementation issues. |
|
|
||
| ### Announcements | ||
|
|
||
| - [CAP-0019](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0019.md) (Future-upgradable TransactionEnvelope type) is moving to Accepted. |
|
|
||
| - Discussing next steps for trustlines work. | ||
| - David personally doesn't feel good about pushing forward Sponsored Trustlines, despite multiple people who think it's mostly there (Tom, Orbit). | ||
| - There was initial discussion of going back to [SEP-0016 (atp3 account transfer)](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0016.md). |
| - CAP-10 | ||
| - CAP-13 | ||
| - CAP-15 | ||
| - CAP-5 |
| - [CAP-0005](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0005.md) & [CAP-0006](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0006.md) - moving to approval. | ||
| - [Cosigned Assets Draft](https://github.com/stellar/stellar-protocol/issues/146) - in draft since September; current approach considered viable. | ||
| - [CAP-0007 Revised Proposal](https://github.com/stellar/stellar-protocol/blob/master/drafts/draft-detacct.md). | ||
| - [CAP-0015](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0015.md) - Bump Fee Transactions update. |
| @@ -0,0 +1,26 @@ | |||
| --- | |||
| title: "2019-11-04" | |||
| description: "This overview highlights validator operations and anchor services." | |||
| @@ -0,0 +1,75 @@ | |||
| --- | |||
| title: "2019-06-27" | |||
| description: "This overview highlights transaction data." | |||
| - What SDF is (and is not): a nonprofit with no shareholders or dividends, focused solely on long-term network adoption and ecosystem health. | ||
| - Decentralization progress: increasing validator independence and a maturing governance feedback loop from community discussion to protocol change. | ||
| - What’s working: scalable technology, a growing global team, stronger community coordination, and expanding ecosystem projects. | ||
| - What needs improvement: stellar-wide marketing, policy and regulatory engagement, ongoing transparency, and more effective lumen distribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #1087