Conversation
Update both `stellar-sdk` and `stellar-sdk-next` aliases from 14.4.3 to 15.0.1 so they stay in lockstep (no protocol transition currently active). Also bumps `@stellar/js-xdr` from ^3.1.2 to ^4.0.0 to match what stellar-base@15 pulls in. Without this, the root XdrReader used in src/helper/soroban-rpc/network.ts diverges from the js-xdr 4 reader that `xdr.ScSpecEntry.read()` expects, and `reader.remainingBytes is not a function` fires in `parseWasmXdr`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the backend’s Stellar/Soroban client dependencies to align with the @stellar/stellar-base@15 dependency chain and prevent js-xdr reader mismatches during contract spec parsing.
Changes:
- Bump
@stellar/stellar-sdk(viastellar-sdkandstellar-sdk-nextaliases) from14.4.3→15.0.1. - Bump
@stellar/js-xdrfrom^3.1.2→^4.0.0. - Refresh lockfile transitive dependencies pulled in by the new SDK version (e.g.,
axios,commander,follow-redirects).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates direct dependency versions for @stellar/js-xdr and the stellar-sdk / stellar-sdk-next aliases. |
| yarn.lock | Locks new versions of Stellar SDK and transitive dependency updates required by the bump. |
Comments suppressed due to low confidence (1)
package.json:43
@stellar/stellar-sdk@15.0.1brings inaxios@1.14.0(see yarn.lock), while this repo still depends onaxios@^1.7.9, so the install now contains two axios versions. If you want to keep the dependency tree smaller and more uniform, consider bumping the directaxiosdependency to^1.14.0(or otherwise aligning versions) so Yarn can dedupe.
"@stellar/js-xdr": "^4.0.0",
"@urql/core": "^5.0.8",
"ajv": "^8.17.0",
"axios": "^1.7.9",
"dotenv-expand": "^12.0.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Drop the caret so transitive resolution can't float within the 4.x range. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aristidesstaffieri
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@stellar/stellar-sdkfrom 14.4.3 → 15.0.1 (bothstellar-sdkandstellar-sdk-nextaliases stay in lockstep — no protocol transition currently active).@stellar/js-xdrfrom ^3.1.2 → ^4.0.0 to match the version@stellar/stellar-base@15pulls in. Without this, the rootXdrReaderused insrc/helper/soroban-rpc/network.tsdiverges from the js-xdr 4 reader thatxdr.ScSpecEntry.read()expects, andreader.remainingBytes is not a functionfires fromparseWasmXdr. BothparseWasmXdrandisTokenSpectests failed prior to this bump and pass after.Test plan
yarn installcompletes cleanlytsc --noEmitpassesyarn test:ci— 107 passed / 3 skipped / 0 failedparseWasmXdr/ token-spec detection🤖 Generated with Claude Code