Apply bal without executing block for finalized blocks#3928
Draft
Apply bal without executing block for finalized blocks#3928
Conversation
Contributor
Author
|
One problem with this optimization is that receipts cannot be generated without executing the block and so this idea may not be viable if we want to support querying historical receipts via JSON-RPC. |
Contributor
Author
|
We should be able to apply the BAL in this way when downloading the state and catching up during snap sync, assuming that we don't need to keep receipts for those blocks. Once we have implemented snap sync we can revisit this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a sync optimization we can skip executing the block when we have a block access list available for a finalized block. In this case we simply apply the BAL and then persist the ledger changes without executing the transactions.
The function which applies the BAL to the state, loops through each account and writes the last update for each type of change (balance, nonce, code, storage). This should be much faster than executing the full block.
This feature is also used when replaying blocks on startup which should speed up that part which was previously rather slow.