Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Breaking changes?
Note
Low Risk
Low risk: mainly renames/refactors around cairo preprocessed-circuit construction and adds a deterministic test for the preprocessed commitment root; runtime verification/proving logic is unchanged aside from wiring.
Overview
Adds a new unit test that recomputes the cairo verifier preprocessed trace commitment and asserts it matches the hardcoded
PRIVACY_RECURSION_CIRCUIT_PREPROCESSED_ROOT.Refactors naming and structure around cairo preprocessing: renames the embedded bootloader constant to
PRIVACY_BOOTLOADER_JSON, renamesget_preprocessed_cairo_circuittoget_cairo_preprocessed_circuit, and factors outget_cairo_novalue_context(used by both preprocessing and constant-hash tests). Updatesprivacy_proveand dev-dependencies to match, including enablingstwoprover/parallelfeatures for tests.Written by Cursor Bugbot for commit 14dd4a5. This will update automatically on new commits. Configure here.
This change is