feat: pox-5 clarity fixes and improvements - #7085
Closed
hstove-stacks wants to merge 10 commits into
Closed
Conversation
Coverage Report for CI Build 24093631532Coverage increased (+0.1%) to 46.77%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2517 previously-covered lines in 44 files lost coverage.
Coverage Stats
💛 - Coveralls |
brice-stacks
reviewed
Apr 8, 2026
| ;; Iterate over the remaining cycles for a staker and update the total amount of uSTX staked. | ||
| ;; Called from `stake-update` and `stake-update-pooled`. | ||
| (define-private (update-amount-ustx-staked | ||
| (staker principal) |
Contributor
There was a problem hiding this comment.
I think this is confusing to take in a staker parameter here since it's not used. It made me think there was a bug, but then I realized the intention is just to update the reward-cycle-total-staked.
brice-stacks
approved these changes
Apr 16, 2026
Contributor
|
Anything need to be saved from this or can we close it? |
Contributor
Author
|
We can close it! |
|
Closed PR has been locked after 14 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-caller-allowedfunctionality (essentially identical to pox-4 and prior)get-total-ustx-stackedcalculations, along with tests(get version pox-addr)is exactly 1 byte