Skip to content

feat: pox-5 clarity fixes and improvements - #7085

Closed
hstove-stacks wants to merge 10 commits into
stacks-network:pox-5-integrationfrom
hstove-stacks:feat/pox-5-fixes
Closed

feat: pox-5 clarity fixes and improvements#7085
hstove-stacks wants to merge 10 commits into
stacks-network:pox-5-integrationfrom
hstove-stacks:feat/pox-5-fixes

Conversation

@hstove-stacks

Copy link
Copy Markdown
Contributor
  • Adds check-caller-allowed functionality (essentially identical to pox-4 and prior)
  • Adds real get-total-ustx-stacked calculations, along with tests
  • Adds validation that (get version pox-addr) is exactly 1 byte

@hstove-stacks hstove-stacks changed the title Feat/pox 5 fixes feat: pox-5 clarity fixes and improvements Apr 7, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 24093631532

Coverage increased (+0.1%) to 46.77%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 2517 coverage regressions across 44 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

2517 previously-covered lines in 44 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
stackslib/src/chainstate/stacks/boot/mod.rs 985 12.89%
stackslib/src/chainstate/nakamoto/signer_set.rs 362 53.0%
stackslib/src/config/mod.rs 343 48.78%
stackslib/src/chainstate/nakamoto/shadow.rs 332 10.13%
stackslib/src/chainstate/coordinator/mod.rs 128 77.07%
stacks-common/src/util/uint.rs 118 43.71%
stackslib/src/burnchains/mod.rs 30 74.17%
stackslib/src/net/p2p.rs 21 67.94%
stackslib/src/net/api/getsortition.rs 19 57.49%
stackslib/src/chainstate/nakamoto/coordinator/mod.rs 15 79.05%

Coverage Stats

Coverage Status
Relevant Lines: 220075
Covered Lines: 102930
Line Coverage: 46.77%
Coverage Strength: 12434549.88 hits per line

💛 - Coveralls

@aaronb-stacks aaronb-stacks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

;; Iterate over the remaining cycles for a staker and update the total amount of uSTX staked.
;; Called from `stake-update` and `stake-update-pooled`.
(define-private (update-amount-ustx-staked
(staker principal)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is confusing to take in a staker parameter here since it's not used. It made me think there was a bug, but then I realized the intention is just to update the reward-cycle-total-staked.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh good catch, fixed in c215ab7

@CLAassistant

CLAassistant commented May 20, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@brice-stacks

Copy link
Copy Markdown
Contributor

Anything need to be saved from this or can we close it?

@hstove-stacks

Copy link
Copy Markdown
Contributor Author

We can close it!

@hstove-stacks
hstove-stacks deleted the feat/pox-5-fixes branch May 28, 2026 14:11
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Closed PR has been locked after 14 days of inactivity.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants