Skip to content

DNM: Testing kayobe-automation image build#2395

Open
jovial wants to merge 15 commits into
stackhpc/2026.1from
wip/2026.1-fix-build
Open

DNM: Testing kayobe-automation image build#2395
jovial wants to merge 15 commits into
stackhpc/2026.1from
wip/2026.1-fix-build

Conversation

@jovial

@jovial jovial commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jovial jovial requested a review from a team as a code owner June 29, 2026 12:12
@jovial jovial changed the base branch from stackhpc/2025.1 to stackhpc/2026.1 June 29, 2026 12:12

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the configuration to OpenStack 2026.1 (gazpacho), drops support for Rocky Linux 9, updates package repository definitions to Rocky Linux 10.2, and introduces new configuration options for Ansible control hosts, fail2ban, and various service containers. However, the review identified critical issues with undefined variables: etc/kayobe/pulp.yml incorrectly references MariaDB 11.6 instead of the defined 11.4 variables, and etc/kayobe/kolla.yml uses outdated or mismatched OpenSearch 3.x and dashboards repository URL variables.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread etc/kayobe/pulp.yml
Comment on lines +431 to 441
- name: MariaDB 11.6 for RHEL 10
url: "{{ stackhpc_release_pulp_content_url }}/mariadb-11.6/yum/rhel/10/x86_64/{{ stackhpc_pulp_repo_rhel_10_mariadb_11_6_version }}"
distribution_name: "rhel-10-mariadb-11-6-"
base_path: "mariadb-11.6/yum/rhel/10/x86_64/"
required: "{{ stackhpc_pulp_sync_for_local_container_build | bool and stackhpc_pulp_sync_el_10 | bool and 'x86_64' in stackhpc_pulp_rpm_architectures }}"

- name: MariaDB 10.11 for RHEL 10 - aarch64
url: "{{ stackhpc_release_pulp_content_url }}/mariadb-10.11/yum/rhel/10/aarch64/{{ stackhpc_pulp_repo_rhel_10_mariadb_10_11_aarch64_version }}"
distribution_name: "rhel-10-mariadb-10-11-aarch64-"
base_path: "mariadb-10.11/yum/rhel/10/aarch64/"
- name: MariaDB 11.6 for RHEL 10 - aarch64
url: "{{ stackhpc_release_pulp_content_url }}/mariadb-11.6/yum/rhel/10/aarch64/{{ stackhpc_pulp_repo_rhel_10_mariadb_11_6_aarch64_version }}"
distribution_name: "rhel-10-mariadb-11-6-aarch64-"
base_path: "mariadb-11.6/yum/rhel/10/aarch64/"
required: "{{ stackhpc_pulp_sync_for_local_container_build | bool and stackhpc_pulp_sync_el_10 | bool and 'aarch64' in stackhpc_pulp_rpm_architectures }}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The variable stackhpc_pulp_repo_rhel_10_mariadb_11_6_version (and its aarch64 counterpart) is used here, but it is not defined anywhere in the configuration. In etc/kayobe/pulp-repo-versions.yml and etc/kayobe/pulp.yml, the defined version is 11_4 (stackhpc_pulp_repo_rhel_10_mariadb_11_4_version). This mismatch will cause an undefined variable error during Ansible execution. Please update these references to use 11.4 and the corresponding 11_4 variables.

  - name: MariaDB 11.4 for RHEL 10
    url: "{{ stackhpc_release_pulp_content_url }}/mariadb-11.4/yum/rhel/10/x86_64/{{ stackhpc_pulp_repo_rhel_10_mariadb_11_4_version }}"
    distribution_name: "rhel-10-mariadb-11-4-"
    base_path: "mariadb-11.4/yum/rhel/10/x86_64/"
    required: "{{ stackhpc_pulp_sync_for_local_container_build | bool and stackhpc_pulp_sync_el_10 | bool and 'x86_64' in stackhpc_pulp_rpm_architectures }}"

  - name: MariaDB 11.4 for RHEL 10 - aarch64
    url: "{{ stackhpc_release_pulp_content_url }}/mariadb-11.4/yum/rhel/10/aarch64/{{ stackhpc_pulp_repo_rhel_10_mariadb_11_4_aarch64_version }}"
    distribution_name: "rhel-10-mariadb-11-4-aarch64-"
    base_path: "mariadb-11.4/yum/rhel/10/aarch64/"
    required: "{{ stackhpc_pulp_sync_for_local_container_build | bool and stackhpc_pulp_sync_el_10 | bool and 'aarch64' in stackhpc_pulp_rpm_architectures }}"

Comment thread etc/kayobe/kolla.yml
file: "rabbitmq_rabbitmq-server.repo"
tag: "rabbitmq_rabbitmq-server"
- url: "{{ stackhpc_repo_opensearch_2_x_url }}"
- url: "{{ stackhpc_repo_opensearch_3_x_url }}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The variable stackhpc_repo_opensearch_3_x_url is used here, but in etc/kayobe/stackhpc.yml it is defined as stackhpc_repo_opensearch_3_x_yum_url (with _yum_). This mismatch will cause an undefined variable error. Please update this to stackhpc_repo_opensearch_3_x_yum_url.

Additionally, note that stackhpc_repo_opensearch_dashboards_2_x_url on line 235 is also undefined because the 2.x variables were removed and replaced with 3.x in etc/kayobe/stackhpc.yml as stackhpc_repo_opensearch_dashboards_3_x_yum_url.

  - url: "{{ stackhpc_repo_opensearch_3_x_yum_url }}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants