Adding a spline joint to the joint collection#2784
Adding a spline joint to the joint collection#2784MegMll wants to merge 96 commits intostack-of-tasks:develfrom
Conversation
There was a problem hiding this comment.
👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:
- build_collision (build Pinocchio with coal support)
- build_casadi (build Pinocchio with CasADi support)
- build_autodiff (build Pinocchio with CppAD support)
- build_codegen (build Pinocchio with CppADCodeGen support)
- build_extra (build Pinocchio with extra algorithms)
- build_mpfr (build Pinocchio with Boost.Multiprecision support)
- build_sdf (build Pinocchio with SDF parser)
- build_accelerate (build Pinocchio with APPLE Accelerate framework support)
- build_all (build Pinocchio with ALL the options stated above)
Thanks.
The Pinocchio development team.
f464bc1 to
660af02
Compare
cfe3213 to
3a119f8
Compare
3c00669 to
1e5d3d3
Compare
aab0161 to
bf16106
Compare
b4923b1 to
86b40d7
Compare
2e60ca8 to
096a5ec
Compare
d5ac733 to
75dacff
Compare
|
Please be aware that modifying the joint collection breaks the API. |
|
@florent-lamiraux We are not considering adding a joint an API break. |
e15d6fb to
00bc40a
Compare
|
@MegMll and I were talking about this PR. As Megan left WILLOW and she is full time on other projects now, it's hard for her to pursue the debugging that this PR requires, and looking for why the tests were not passing. Does anyone would like to help and/or review this PR? Here is the focused help, that would be appreciated and could unlock our next developments.
Let us know in which time frame anyone can help, before @MegMll totally loose track of what she had undertaken. |
|
Hello @Ipuch, Now we released pinocchio 4, I will probably be able to work again on this PR next month. |
f60f2c7 to
025c789
Compare
need to rcheck every test and put all the files in the right folder after rebase of pinocchio 4
|
Okay i won't be available in May, but if i need to make some changes myself, i guess it can wait June, anyway |
|
Thanks @MegMll for rebasing 👍 |
To do
|
|
@MegMll and @LucasJoseph pinocchio/algorithm/splines.hpp also need to be added into the sources.cmake |
Description
In this PR, we introduce the new spline joint to pinocchio. This implementation is based on the paper of Lee et al. available here
It allows to define a number of SE3 frames, that will define the movement and dynamics of the joint. It's very useful for biomechanics, but can be used in other applications.
To do
Future