Update getting started guide for 25.10 and srl image for greeter app#203
Merged
Update getting started guide for 25.10 and srl image for greeter app#203
Conversation
|
🏗 Preview site has been deployed to: |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the MkDocs Material documentation tooling infrastructure and updates the SR Linux version reference in the greeter app tutorial from 25.3 to 25.10.
- Migrates from
registry.srlinux.devtoghcr.io/eda-labsfor MkDocs Material container images - Updates MkDocs Material version from 9.6.16-insiders-4.53.16-hellt to v9.7.1-1
- Upgrades GitHub Actions runners from Ubuntu 22.04 to Ubuntu 24.04
- Updates SR Linux version reference in tutorial documentation from 25.3 to 25.10
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/ndk/guide/dev/go/with-bond/index.md | Updates SR Linux version reference from 25.3 to 25.10 in the tutorial prerequisites |
| Makefile | Refactors build tooling to use new MkDocs Material image from ghcr.io/eda-labs, simplifies target names, and fixes spelling in comment |
| .github/workflows/cicd.yml | Updates CI/CD workflow to use new MkDocs Material image and upgrades runner OS to Ubuntu 24.04 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// note | ||
| attrs: {class: inline end} | ||
| [Containerlab v0.68.0](https://containerlab.dev/install) version, `srl-labs/bond` v0.3.0 and SR Linux 25.3 are used in this tutorial. Users are advised to use these version to have the same outputs as in this tutorial. | ||
| [Containerlab v0.68.0](https://containerlab.dev/install) version, `srl-labs/bond` v0.3.0 and SR Linux 25.10 are used in this tutorial. Users are advised to use these version to have the same outputs as in this tutorial. |
There was a problem hiding this comment.
Grammar error: 'these version' should be 'these versions' (plural) since it refers to multiple items (Containerlab, bond, and SR Linux).
Suggested change
| [Containerlab v0.68.0](https://containerlab.dev/install) version, `srl-labs/bond` v0.3.0 and SR Linux 25.10 are used in this tutorial. Users are advised to use these version to have the same outputs as in this tutorial. | |
| [Containerlab v0.68.0](https://containerlab.dev/install) version, `srl-labs/bond` v0.3.0 and SR Linux 25.10 are used in this tutorial. Users are advised to use these versions to have the same outputs as in this tutorial. |
|
🏗 Preview site has been deployed to: |
|
🏗 Preview site has been deployed to: |
|
🏗 Preview site has been deployed to: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.