Skip to content

430 add ability to search filter expenses#1374

Open
MilouH-TUE wants to merge 7 commits intospiral-project:mainfrom
MilouH-TUE:430-add-ability-to-search-filter-expenses
Open

430 add ability to search filter expenses#1374
MilouH-TUE wants to merge 7 commits intospiral-project:mainfrom
MilouH-TUE:430-add-ability-to-search-filter-expenses

Conversation

@MilouH-TUE
Copy link
Copy Markdown

Closes #430

I created this pull request in collaboration with @c5laungani . This merge request adds filter options for the bills list as requested in issue 430. We used the previous attempts for this issue as our starting point. Just before opening this pull request, we also observed that there was another issue (1155), that is a duplicate of the filtering issue. In a recent pull request for that issue, the feedback was to add tests. So in this pull request we tried to cover all feedback from previous attempts.

Screenshots:
filter_closed
filter_shown
filter_applied

Demo video:
https://github.com/user-attachments/assets/40465943-3819-4158-b642-b3fc5899c065

Please let us know if there's anything we should look into further!

@Jojo144
Copy link
Copy Markdown
Contributor

Jojo144 commented Apr 5, 2026

Thanks for your contribution! And sorry for the very late answer.
Here are my first comments:

  • it should nice to have a "for whom" field, it is useful
  • we should be accent insensitive (useful in french)
  • does "Clear filters" should really dismiss the panel? I would prefer not.
  • I think that the "Filter" button should be normal size instead of btn-sm

@Jojo144
Copy link
Copy Markdown
Contributor

Jojo144 commented Apr 5, 2026

Also:

  • we should accept comma in "min" and "max" fields and replace it by a dot
  • the links are wrong when there are several pages (it clean the filters)

I tested on a project with lot of bills, it will be very handy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to search / filter expenses

2 participants