fix the fetching of the image in src when using responsive images#99
Open
svdvonde wants to merge 3 commits intosparanoid:masterfrom
Open
fix the fetching of the image in src when using responsive images#99svdvonde wants to merge 3 commits intosparanoid:masterfrom
svdvonde wants to merge 3 commits intosparanoid:masterfrom
Conversation
Author
|
Note: the current pull request still gives rise to a network call, which has the potential to be slow to resolve when the network connection is slow. Compared to the unmodified library, at least the network call returns with a http |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposed fix for issue #98. Instead of using
img.src, use the read-only propertyimg.currentSrcinstead. This property is supported by all major browsers.