Updates GeneralUser GS soundfont to v2.0.3#43702
Open
Menshin wants to merge 1 commit intospace-wizards:masterfrom
Open
Updates GeneralUser GS soundfont to v2.0.3#43702Menshin wants to merge 1 commit intospace-wizards:masterfrom
Menshin wants to merge 1 commit intospace-wizards:masterfrom
Conversation
PJBot
added
S: Untriaged
Contributor
Author
|
Test failing with |
Contributor
i spent the better half of today updating my old pr and having the same issue i have a sneaking suspicion it might have to do with #43659 since that touches maxcaps and was merged super recently. yours is the first other pr i've seen with the same issue despite neither of us touching anything relevant to it |
Member
|
Yes, that test failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Updates the GeneralUser GS soundfont to last version (2.0.3, from 2.0.2) from their repo (https://github.com/mrbumpy409/GeneralUser-GS).
Changelog reproduced below :
Why / Balance
We all love those MIDI playing moments, may as well enjoy them with non-degraded samples.
Media
None required i think.
Requirements
Breaking changes
None, all tested fine.
Changelog
Do we require one for a maintenance PR ?