Move HTN Preconditions and Operators to IDependencyCollection instead of IoCManager#43694
Move HTN Preconditions and Operators to IDependencyCollection instead of IoCManager#43694jessicamaybe wants to merge 10 commits intospace-wizards:masterfrom
Conversation
|
Goated work. |
|
Just a thought for the future, maybe having EntityManager provided by HtnPrecondition to dedupe that dependency further? Similar to commands. |
At that point preconditions should just be entity systems (and they should be) |
I wasn't aware that was a possibility :godo: |
At some point I plan on migrating preconditions to use EntityCondition, but for now i think this is fine. That's waiting on a few PRs and some other work to make them faster edit: i replied to the wrong post, you already know this they are your prs |
Princess-Cheeseballs
left a comment
There was a problem hiding this comment.
Looks good, only one whitespace issue I saw.
About the PR
Moved HTN Preconditions and Operators to IDependencyCollection instead of IoCManager
Why / Balance
its 2026 I don't want to use
IEntityManager.System<T>for everythingTechnical details
Media
Requirements
Breaking changes
HTNOperator's andHTNPrecondition's now resolve their dependencies viaIDependencyCollectioninstead ofIoCManagerHTN Operators and Preconditions will need to be refactored to to use
[Dependency]instead of_entMan.System<T>Changelog