feat: std.textureSampleGrad (+ docs: POM example)#2366
Open
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:
📋 All resultsClick to reveal the results table (350 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
Adds a new Parallax Occlusion Mapping (POM) rendering example to the TypeGPU docs site, and introduces the missing std.textureSampleGrad stdlib binding needed by the example’s gradient-based texture sampling.
Changes:
- Add
textureSampleGradtotypegpu/std(CPU stub + WGSL codegen + barrel export). - Introduce a new docs example at
rendering/pom(types, shaders, runtime, meta, and canvas HTML). - Add new POM material texture assets under
apps/typegpu-docs/public/assets/pom/**.
Reviewed changes
Copilot reviewed 7 out of 44 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/typegpu/src/std/texture.ts | Adds textureSampleGrad dualImpl + overload typings. |
| packages/typegpu/src/std/index.ts | Re-exports textureSampleGrad from the std barrel. |
| apps/typegpu-docs/src/examples/rendering/pom/types.ts | Defines vertex/params schemas, constants, and helpers for the POM example. |
| apps/typegpu-docs/src/examples/rendering/pom/shaders.ts | Adds PBR helper functions and POM math helpers used by the fragment shader. |
| apps/typegpu-docs/src/examples/rendering/pom/meta.json | Registers the example in the docs gallery (title/category/tags/coolFactor). |
| apps/typegpu-docs/src/examples/rendering/pom/index.ts | Implements the interactive POM demo: texture loading, ray-march shading, controls, resize handling, cleanup. |
| apps/typegpu-docs/src/examples/rendering/pom/index.html | Provides the canvas container for the example. |
| apps/typegpu-docs/public/assets/pom/** | Adds new texture assets used by the POM materials. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iwoplaza
changed the title
iwoplaza
approved these changes
Apr 13, 2026
Collaborator
iwoplaza
left a comment
iwoplaza
left a comment
There was a problem hiding this comment.
Let's gooo! 🧱
Left just a handful of nits
|
|
||
| const prevGap = prevSurfaceDepth - prevDepth; | ||
| const currGap = surfaceDepth - depth; | ||
| const t = std.clamp(prevGap / (prevGap - currGap), 0, 1); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const t = std.clamp(prevGap / (prevGap - currGap), 0, 1); | |
| const t = std.saturate(prevGap / (prevGap - currGap)); |
| shadowFactor = std.min(shadowFactor, (softShadowMultiplier * gap) / marchedDepth); | ||
| } | ||
|
|
||
| shadowFactor = std.clamp(shadowFactor, 0, 1); |
Collaborator
There was a problem hiding this comment.
Suggested change
| shadowFactor = std.clamp(shadowFactor, 0, 1); | |
| shadowFactor = std.saturate(shadowFactor); |
Collaborator
There was a problem hiding this comment.
Could you pick a more... pleasing material? 🙏 💩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.