Fix: Replace blake2b with FIPS-compatible hash fallback to support secure environments#2357
Open
sumit-gupta-sgt wants to merge 3 commits intosodadata:v3from
Open
Fix: Replace blake2b with FIPS-compatible hash fallback to support secure environments#2357sumit-gupta-sgt wants to merge 3 commits intosodadata:v3from
sumit-gupta-sgt wants to merge 3 commits intosodadata:v3from
Conversation
|
Sumit Gupta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
for more information, see https://pre-commit.ci
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This PR replaces all direct uses of
hashlib.blake2b()with a utility functionfips_safe_hasher()that falls back to a truncatedsha256()hash in FIPS-enabled environments.This resolves failures such as:
...which occur because
blake2bis disabled when Python is compiled against OpenSSL in FIPS mode.Key Changes
fips_safe_hasher()insoda/common/utils/hash_utils.py.blake2busage across the codebase with this safe wrapper.Why This Matters
In regulated or security-hardened systems (e.g., federal workloads, STIG-compliant Linux), FIPS mode is required and disables non-compliant hash functions like BLAKE2. This change ensures Soda Core works in those environments without modification or monkey-patching.
Compatibility
Related
Happy to adjust or expand test coverage as needed!