Skip to content

chore(hub): drop vestigial settings IS NOT NULL guards on spaces #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wa0x6e wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore(hub): drop vestigial settings IS NOT NULL guards on spaces #2221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7261b9e
chore(hub): drop vestigial settings IS NOT NULL guards on spaces
wa0x6e Jul 11, 2026
ab50572
test(sequencer): mark spaces.settings NOT NULL in schema
wa0x6e Jul 11, 2026
3aac039
Merge branch 'master' into fix/2220
wa0x6e Jul 12, 2026
baac61f
Merge branch 'master' into fix/2220
wa0x6e Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/hub/src/graphql/operations/proposal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default async function (parent, { id }) {
FROM proposals p
INNER JOIN spaces ON spaces.id = p.space
LEFT JOIN skins ON spaces.id = skins.id
WHERE p.id = ? AND spaces.settings IS NOT NULL
WHERE p.id = ?
LIMIT 1
`;
try {
Expand Down
2 changes: 1 addition & 1 deletion apps/hub/src/graphql/operations/subscriptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default async function (parent, args) {
FROM subscriptions s
INNER JOIN spaces ON spaces.id = s.space
LEFT JOIN skins ON spaces.id = skins.id
WHERE spaces.settings IS NOT NULL ${queryStr}
WHERE 1=1 ${queryStr}
ORDER BY ${orderBy} ${orderDirection} LIMIT ?, ?
`;
params.push(skip, first);
Expand Down
4 changes: 2 additions & 2 deletions apps/hub/src/graphql/operations/votes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ async function query(parent, args, context?, info?) {
.filter((v, i, a) => a.indexOf(v) === i);
const query = `
SELECT * FROM spaces
WHERE id IN (?) AND settings IS NOT NULL AND deleted = 0
WHERE id IN (?) AND deleted = 0
`;
try {
let spaces = await db.queryAsync(query, [spaceIds]);
Expand Down Expand Up @@ -106,7 +106,7 @@ async function query(parent, args, context?, info?) {
FROM proposals p
INNER JOIN spaces ON spaces.id = p.space
LEFT JOIN skins ON spaces.id = skins.id
WHERE spaces.settings IS NOT NULL AND p.id IN (?)
WHERE p.id IN (?)
`;
try {
let proposals = await db.queryAsync(query, [proposalIds]);
Expand Down
2 changes: 1 addition & 1 deletion apps/hub/src/helpers/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
CREATE TABLE spaces (
id VARCHAR(64) NOT NULL,
name VARCHAR(64) NOT NULL,
settings JSON,
settings JSON NOT NULL,

@ChaituVR ChaituVR Jul 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is same on prod DB? 🤔

@wa0x6e wa0x6e Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this will need a schema update on the prod database

@wa0x6e wa0x6e Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy request: https://app.planetscale.com/snapshot/snapshot-hub/deploy-requests/22

@bonustrack confirm, then we can merge

Already changed on testnet

verified INT NOT NULL DEFAULT '0',
deleted INT NOT NULL DEFAULT '0',
flagged INT NOT NULL DEFAULT '0',
Expand Down
2 changes: 1 addition & 1 deletion apps/sequencer/test/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
CREATE TABLE spaces (
id VARCHAR(64) NOT NULL,
name VARCHAR(64) NOT NULL,
settings JSON,
settings JSON NOT NULL,
verified INT NOT NULL DEFAULT '0',
deleted INT NOT NULL DEFAULT '0',
flagged INT NOT NULL DEFAULT '0',
Expand Down
Loading