docs: resync skills with smg HEAD (v1.5.0) - #19
Merged
Conversation
Skills were last verified against smg on 2026-06-08; ~123 commits have landed since. Audited every recipe against the current code (not commit messages) and fixed the drift. Removed/renamed (factual fixes): - map, implement: drop the removed `tui`/`smg-tui` crate; add the new `mock_worker` crate; fix the repo-root directory-layout line. - mcp: drop the removed `oauth.rs` from the module map. - observability: drop the removed `/ws/metrics` WebSocket; document the new `runtime_metrics.rs` (event-loop canary + runtime sampler). - tenancy: drop the removed `TenantAliasStore`/`resolve_tenant_key` alias remap (resolution is now infallible); note the new `request_charge_id` field on `RouteRequestMeta`. - routing-policy: `get_all_power_of_two_policies()` -> `get_all_load_aware_policies()`; add `remove_worker`. - rate-limit: `middleware/scheduler.rs` -> `middleware/scheduler/`; correct the `with_admission_layer` behaviour. - config-plumbing: rewrite the to_router_config/to_server_config snippet to the real `&self` builder / struct-literal shape. - contribute: clippy gate gains `--workspace`; add `std::process::exit` to the disallowed-methods table. New coverage: - provider-api: shared SSE codec (SseEncoder/SseDecoder) + protocol fidelity (serde flatten / function_call pairing). - grpc-backend: 4th macro impl_admin_ops!, per-engine macro matrix, TokenSpeed engine, get_loads/subscribe_kv_events, DP-rank pinning. - kv-index: fused match_and_insert; removal of the 2048-worker cap. - mesh: MeshAdapters composition root + outbound worker mesh sync. - multimodal: ABI-generalization renames (VisionPreProcessor, PreprocessedEncoderInputs, ...) + first-class video modality. - mcp: BuiltinToolType builtin-tool classification. Also de-brittled all `file.rs:NNN` line references to file + symbol anchors so they survive upstream churn. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SMG development skills were last verified against smg on 2026-06-08. Since then ~123 commits have landed in the smg codebase (now v1.5.0), leaving the skills with stale crate names, removed subsystems, drifted APIs, and
file.rs:NNNline references that no longer match.Solution
Audited all 24 skill files against smg HEAD by reading the current source (not commit messages — e.g. a "rename
least_load" commit was misleading; the policy still exists and the count was correct). Fixed every factual drift, added coverage for new subsystems, and de-brittled allfile.rs:NNNreferences tofile.rs+ symbol-name anchors so they survive smg's churn.Changes
Removed / renamed (factual fixes)
map/SKILL.md— drop removedtui/smg-tuicrate; add newmock_workercrate; fix repo-root layout line; Router params~80→~110; broaden discovery-DAG steps path.implement/SKILL.md— drop removed Terminal UI/tui/row.mcp-feature.md— drop removedoauth.rsfrom the module map.observability-feature.md— drop removed/ws/metricsWebSocket; document newruntime_metrics.rs.tenancy-feature.md— drop removedTenantAliasStore/resolve_tenant_key(resolution now infallible); note newrequest_charge_idfield.routing-policy.md—get_all_power_of_two_policies()→get_all_load_aware_policies(); addremove_worker.rate-limit-feature.md—middleware/scheduler.rs→middleware/scheduler/; correctwith_admission_layer.config-plumbing.md— rewrite Step 4 to the real&selfbuilder / struct-literal shape.storage-backend.md—data-connectorv2.2.0→v2.3.0.contribute/SKILL.md— clippy gate--workspace; addstd::process::exitdisallowed-method; clarifygenerate-clientsscope.New coverage
provider-api.md— shared SSE codec (SseEncoder/SseDecoder) + protocol fidelity (serde flatten,function_callpairing).grpc-backend.md— 4th macroimpl_admin_ops!, per-engine macro matrix, TokenSpeed engine,get_loads/subscribe_kv_events, DP-rank pinning.kv-index-feature.md— fusedmatch_and_insert; removal of the 2048-worker cap.mesh-feature.md— MeshAdapters composition root + outbound worker mesh sync; watermark op-id tie-break.multimodal-feature.md— ABI-generalization renames (VisionPreProcessor,PreprocessedEncoderInputs, …) + first-class video modality.mcp-feature.md—BuiltinToolTypebuiltin-tool classification.discovery-feature.md—kv_engine_idspecial key +tokenspeedbackend.reasoning-parser.md—find_pooled_parser_for_model→create_for_model;QwenThinkingParserexample.tool-parser.md— MiniMax-M2 schema coercion / unknown-name forwarding.bindings-update.md—PolicyType↔PolicyConfigsync callout.review-pr/SKILL.md— note routers now includeresponses/,conversations/,grpc/.Durability — all recipes:
file.rs:NNNline refs replaced withfile.rs+ symbol anchors.Affected Skills
smg:mapsmg:contributesmg:review-prsmg:implementskills/implement/)smg.md) — verified, unchangedplugin.json) — unchangedChecklist
git commit -s)claude plugins add .locally — not run; all content verified against smg HEAD by reading source, and the 11 most load-bearing new symbols confirmed at their cited pathsdescription:frontmatter changed, so triggers are unaffected@file.mdreferences in skills