Skip to content

Node and don IDs --> struct for encapsulation#419

Merged
patrickhuie19 merged 2 commits into
mainfrom
feat/metering-followups
Jul 1, 2026
Merged

Node and don IDs --> struct for encapsulation#419
patrickhuie19 merged 2 commits into
mainfrom
feat/metering-followups

Conversation

@patrickhuie19

@patrickhuie19 patrickhuie19 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor
  • Added tenant as a separate line item from product
  • Made Don Identifier struct to hold both node and don ID for easier handling in go consumers
  • updated codeowners to flag cre-business group as they are downstream consumers

For reviewers: this proto is still fresh, i.e. not used in production, so no concerns with backwards compatability

@patrickhuie19 patrickhuie19 requested review from a team as code owners July 1, 2026 18:17
@changeset-bot

changeset-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0a81c3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

👋 patrickhuie19, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedJul 1, 2026, 6:20 PM

@patrickhuie19 patrickhuie19 requested a review from MStreet3 July 1, 2026 18:39
@patrickhuie19 patrickhuie19 merged commit 696c075 into main Jul 1, 2026
23 checks passed
@patrickhuie19 patrickhuie19 deleted the feat/metering-followups branch July 1, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants