Add debug logging for MULTI_SHARD_AUTOCOMMIT transaction path#832
Draft
tanjinx wants to merge 1 commit intoslack-22.0from
Draft
Add debug logging for MULTI_SHARD_AUTOCOMMIT transaction path#832tanjinx wants to merge 1 commit intoslack-22.0from
tanjinx wants to merge 1 commit intoslack-22.0from
Conversation
Adds log lines at three decision points to diagnose whether vtgate uses autocommit or explicit BEGIN for multi-shard DMLs: - vtgate execMultiShard: logs autocommit decision inputs and result - vtgate actionInfo: logs per-shard transaction/begin decision - vttablet Execute vs BeginExecute: confirms which RPC path is taken Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds log lines at three decision points to diagnose whether vtgate uses autocommit or explicit BEGIN for multi-shard DMLs:
Description
Related Issue(s)
Checklist
Deployment Notes
AI Disclosure