Skip to content

chore!: remove deprecated --branch and --template flags from samples command#466

Merged
zimeg merged 2 commits intomainfrom
zimeg-chore-remove-samples-repo-flags
Apr 7, 2026
Merged

chore!: remove deprecated --branch and --template flags from samples command#466
zimeg merged 2 commits intomainfrom
zimeg-chore-remove-samples-repo-flags

Conversation

@zimeg
Copy link
Copy Markdown
Member

@zimeg zimeg commented Apr 2, 2026

Changelog

We removed the deprecated --branch and --template flags from the samples command to now prefer the create command when repository details are known.

Summary

🪓 This PR removes the hidden --branch and --template flags from the samples command, along with the deprecation warning and dead flag forwarding logic. The create command should be used directly when a specific template or branch is needed.

Requirements

…ples` command

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg zimeg requested a review from a team as a code owner April 2, 2026 20:25
@zimeg zimeg added this to the Next Release milestone Apr 2, 2026
@zimeg zimeg added changelog Use on updates to be included in the release notes code health M-T: Test improvements and anything that improves code health semver:major Use on pull requests to describe the release version increment labels Apr 2, 2026
@zimeg zimeg self-assigned this Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.03%. Comparing base (2927885) to head (185ff20).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
- Coverage   71.05%   71.03%   -0.03%     
==========================================
  Files         220      220              
  Lines       18519    18504      -15     
==========================================
- Hits        13159    13144      -15     
- Misses       4181     4183       +2     
+ Partials     1179     1177       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@srtaalej srtaalej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, works great! 🌟

@zimeg
Copy link
Copy Markdown
Member Author

zimeg commented Apr 7, 2026

@srtaalej I appreciate the confidence shared! Let's celebrate with merging this next 🚢 💨

@zimeg zimeg enabled auto-merge (squash) April 7, 2026 06:17
@zimeg zimeg merged commit c56ad55 into main Apr 7, 2026
8 checks passed
@zimeg zimeg deleted the zimeg-chore-remove-samples-repo-flags branch April 7, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog Use on updates to be included in the release notes code health M-T: Test improvements and anything that improves code health semver:major Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants