test(ci): run the installation tests on circleci#225
Conversation
zimeg
added
code health
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 62.90% 62.91%
=======================================
Files 212 212
Lines 21782 21782
=======================================
+ Hits 13703 13705 +2
+ Misses 7014 7011 -3
- Partials 1065 1066 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
📠 Quick notes for the kind reviewers!
| - run: | ||
| name: Run Install Tests | ||
| command: | | ||
| make test-install |
There was a problem hiding this comment.
🔍 note: Ahha! Just as we hoped:
🔗 Adding a symbolic link from /home/circleci/.local/bin/slack-test to /home/circleci/.slack/bin/slack
There was a problem hiding this comment.
🪬 ramble: Compared to:
🔗 Adding a symbolic link from /usr/local/bin/slack-test to ~/.slack/bin/slack
https://github.com/slackapi/slack-cli/actions/runs/17590393385/job/49969493179#step:6:34
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Nice, thanks for this follow-up!
|
@mwbrooks Blessed be the reminders of a post it note. Thanks too for the review! |
2 participants
Summary
This PR retruns the changes of 6001989 following #188! 👾 ✨
Reference: #188 (comment)
Notes
These tests should now fallback to using the
$HOME/.local/binpath in CircleCI due to permission setups, and/usr/local/binon GitHub Actions IIRC?Requirements