onStart/onFinish gesture callbacks, gesture type, new Sliders#159
Closed
Azerlag wants to merge 13 commits intoskydoves:mainfrom
Closed
onStart/onFinish gesture callbacks, gesture type, new Sliders#159Azerlag wants to merge 13 commits intoskydoves:mainfrom
Azerlag wants to merge 13 commits intoskydoves:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! For my project I needed to add new callbacks to the UI elements, so I forked the repo and made my own changes. Increase lib version please, I did not do that.
Compose components build successfully (only tested for AndroidRelease), artifacts are on jitpack: https://jitpack.io/#azerlag/colorpicker-compose
Thanks.
🎯 Goal
Add
onStart/onFinishgesture callbacks to all interactive components,introduce
ColorChangeSourcetoColorEnvelope, and add two new slidercomponents:
HueSliderandSaturationSlider.🛠 Implementation details
ColorChangeSourceenum added toColorEnvelopewith three values:Tap— color changed via tap gestureDrag— color changed via drag gestureProgrammatic— fallback for programmatic changes (e.g. initial setup)The source is passed through the entire chain: gesture → controller →
notifyColorChanged→ColorEnvelope.onStart/onFinishlambdas added toHsvColorPicker,AlphaSlider,BrightnessSliderand other. Implemented viadetectTapGestures(onPress)anddetectDragGestures(onDragStart, onDragEnd, onDragCancel).HueSliderandSaturationSliderfollow the same architecture asAlphaSliderandBrightnessSlider. Controller gainshue,saturationstate fields,
setHue/setSaturationmethods, andisAttachedHueSlider/isAttachedSaturationSliderflags.applyHSVFactorsis updated accordingly.✍️ Explain examples