ci: drop redundant docker login from docker_push.sh#963
Merged
JohannesLichtenberger merged 1 commit intomainfrom Apr 29, 2026
Merged
ci: drop redundant docker login from docker_push.sh#963JohannesLichtenberger merged 1 commit intomainfrom
JohannesLichtenberger merged 1 commit intomainfrom
Conversation
The workflow's `Login to Docker Hub` step (docker/login-action@v3) already authenticates against Docker Hub before this script runs. The script's own `docker login` reads $DOCKER_USERNAME and $DOCKER_PASSWORD, which the workflow does not export — so it failed with `Must provide --username with --password-stdin` on every push to main, blocking the deploy job. Drop the redundant login and add `set -euo pipefail` so any future build/push failure surfaces clearly instead of being masked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deploy to OSSRH and Docker Hubjob has been failing on every push to main with:— see run 25133490213.
Cause:
docker_push.shruns its owndocker loginusing$DOCKER_USERNAME/$DOCKER_PASSWORD. Those env vars are not exported by the workflow — authentication is already handled by the previous step (docker/login-action@v3, withDOCKERHUB_USERNAME/DOCKERHUB_TOKEN). So the script's login runs without credentials and aborts.This PR removes the redundant login and adds
set -euo pipefailso future build/push failures surface clearly.Test plan
Deploy to OSSRH and Docker Hubjob; the Docker Hub step now succeeds (docker compose build/docker compose pushrun with the credentials established bydocker/login-action).bash -n docker_push.shparses cleanly.