Skip missing entry points for lifecycle-built packages#782
Merged
sindresorhus merged 1 commit intomainfrom Apr 4, 2026
Merged
Conversation
Keep `npm pack --dry-run` script-free when collecting packed files so prerequisite checks do not fail on broken lifecycle hooks or noisy script output. Still run entry-point validation against that stable packlist, but only skip the failure when an entry point is missing and the package declares pack-related lifecycle scripts. That preserves validation for packages whose entry points are already present without scripts, while avoiding false negatives for packages that generate publishable files during `prepare` or `prepack`. Fixes #780
fregante
approved these changes
Apr 4, 2026
Collaborator
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
I'm not sure about the consequences of this change but the added flag and following tests seem to be what I want 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep
npm pack --dry-runscript-free when collecting packed files so prerequisite checks do not fail on broken lifecycle hooks or noisy script output.Still run entry-point validation against that stable packlist, but only skip the failure when an entry point is missing and the package declares pack-related lifecycle scripts. That preserves validation for packages whose entry points are already present without scripts, while avoiding false negatives for packages that generate publishable files during
prepareorprepack.Fixes #780