Drop Python 3.8/3.9 support and remove Holography agents#1040
Draft
BrianJKoopman wants to merge 3 commits intov0.7.0-devfrom
Draft
Drop Python 3.8/3.9 support and remove Holography agents#1040BrianJKoopman wants to merge 3 commits intov0.7.0-devfrom
BrianJKoopman wants to merge 3 commits intov0.7.0-devfrom
Conversation
They have Python 3.8 only dependencies, and no one is maintaining them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR is into the
v0.7.0-devbranch, notmain. Keeping thing separated frommainuntilv0.6.1is released.Description
This PR formally drops Python 3.8/3.9 support and removes the Holography agents (which depend on Python 3.8). It also re-adds Python 3.12 to the CI tests.
Motivation and Context
We're following the plans in
ocsforv0.13.0and dropping end of life Python versions. This also allows us to use the official published versions of some of our dependencies (namelysotodlibandsodetlib.)Resolves #1035.
How Has This Been Tested?
This has not yet been tested. I need to see how the CI runs, hence the draft PR. I'll also do some local testing before we merge this.
I also still need to update the develop and deploy workflows to a non Python 3.8 version -- they're probably going to break for now...
Types of changes
Checklist: