Remove file sequence and prefix options from translate.py#1064
Conversation
…m translate.py Agent-Logs-Url: https://github.com/sillsdev/silnlp/sessions/924c5c94-b356-4689-9dd3-d9bd037e281b Co-authored-by: benjaminking <1214233+benjaminking@users.noreply.github.com>
|
I believe that the coding agent has removed all of the material related to file sequences and prefixes from the code base. I have verified that tests pass and other modes of translation are unaffected. |
|
I also had to revert a recent change that produced an error when there was a mismatch between tokenizer sizes back to being a warning. The experiment smoke test uses Huggingface's
I ended up going with option 4, since it seemed like it would have a relatively small impact on production use-cases, but would allow tests to have broader coverage without much development effort. In the long term, I think option 3 is probably best. In fact, I'll add a comment to the line with the warning to mention that we could have it be an error one we do the right refactorization. |
mshannon-sil
left a comment
There was a problem hiding this comment.
I think converting it to a warning for now given the circumstances with testing is fine.
@mshannon-sil made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on benjaminking).
The
--src-prefix,--trg-prefix,--start-seq, and--end-seqarguments intranslate.pysupported batch translation of sequentially-numbered files — functionality no longer used in production.Removed
--src-prefix,--trg-prefix,--start-seq,--end-seqCLI arguments frommain()TranslationTask.translate_text_files()method and all call sitessrc_prefixbranch inexperiment.py'stranslate()dispatch logicimport time(was only used intranslate_text_files)Updated
--save-confidenceshelp text: removed reference to.txtsequence file confidenceselseerror messages in bothtranslate.pyandexperiment.py: removed mention of "file prefix"This change is