Conversation
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3870 +/- ##
==========================================
+ Coverage 76.74% 76.75% +0.01%
==========================================
Files 115 115
Lines 12369 12369
==========================================
+ Hits 9492 9494 +2
+ Misses 2877 2875 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
flying-sheep
requested changes
Nov 10, 2025
Member
flying-sheep
left a comment
flying-sheep
left a comment
There was a problem hiding this comment.
Great work!
Only issue I see is that all the array_type.__name__ checking is already fragile enough, so let’s make it better or keep it instead of making it more fragile.
flying-sheep
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: why wasn't scverse/anndata#2087 merged into the patch release branch?