Skip to content

remove the legacy update()#132

Merged
ilia-kats merged 2 commits intoscverse:mainfrom
ilia-kats:remove_legacy_update
Apr 14, 2026
Merged

remove the legacy update()#132
ilia-kats merged 2 commits intoscverse:mainfrom
ilia-kats:remove_legacy_update

Conversation

@ilia-kats
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.96%. Comparing base (d1177b1) to head (31b5993).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   91.02%   90.96%   -0.07%     
==========================================
  Files          11       11              
  Lines        1805     1638     -167     
==========================================
- Hits         1643     1490     -153     
+ Misses        162      148      -14     
Files with missing lines Coverage Δ
src/mudata/_core/config.py 90.90% <100.00%> (ø)
src/mudata/_core/io.py 94.97% <100.00%> (-0.02%) ⬇️
src/mudata/_core/mudata.py 93.50% <100.00%> (+0.31%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilia-kats ilia-kats force-pushed the remove_legacy_update branch 5 times, most recently from 4f26606 to 73c47f6 Compare March 30, 2026 08:38
@ilia-kats ilia-kats force-pushed the remove_legacy_update branch from 73c47f6 to 5f0d8d4 Compare April 10, 2026 15:58
@ilia-kats ilia-kats marked this pull request as ready for review April 10, 2026 16:01
@ilia-kats ilia-kats requested review from gtca and ilan-gold and removed request for gtca April 10, 2026 16:01
Copy link
Copy Markdown
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think the test is just because there is no explicit pull now?

@ilia-kats
Copy link
Copy Markdown
Collaborator Author

Nice! I think the test is just because there is no explicit pull now?

Yeah, exactly, forgot to change the comment after changing the code. Fixed the comment, merging.

@ilia-kats ilia-kats merged commit db52ec5 into scverse:main Apr 14, 2026
9 checks passed
@ilia-kats ilia-kats deleted the remove_legacy_update branch April 14, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants