Fix index retention in _tensor_truth function#302
Merged
PauBadiaM merged 3 commits intoscverse:mainfrom Apr 13, 2026
Merged
Conversation
Ensure the grts retains original index after pivoting. Currently shuffles grout truth tensor compared to activities inferred by decouple
for more information, see https://pre-commit.ci
The index-alignment fix in _tensor_truth exposed that metrics5 was accidentally passing due to misaligned ground truth. With groupby="group", every source within each group has homogeneous perturbation (all 1s or all 0s), producing no metrics. Using "class" (which mixes groups A and B) ensures heterogeneous ground truth for meaningful source-level evaluation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PauBadiaM
added a commit
that referenced
this pull request
Apr 13, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
- Coverage 94.31% 94.31% -0.01%
==========================================
Files 78 78
Lines 4079 4078 -1
==========================================
- Hits 3847 3846 -1
Misses 232 232
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the grts retains original index after pivoting. Currently shuffles grout truth tensor compared to activities inferred by decouple