add eval capes to sdk#460
Open
luke-e-schaefer wants to merge 7 commits into
Open
Conversation
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/scale-epd/issue/DE-7460
Greptile Summary
EvaluationV2SDK support:NucleusClient.create_evaluation_v2,get_evaluation_v2, andlist_evaluations_v2, plus Pydantic DTOs for charts/examples payloads and a newtests/test_evaluation_v2.pywith mocked-HTTP coverage.EvaluationV2Statusenum is exported publicly butwait_for_completioncomparesself.statusagainst raw string literals instead of using the enum values, creating a silent drift risk.list_evaluations_v2silently returns[]when the API returns an unexpected non-list success body, which could mask malformed responses.Confidence Score: 5/5
Safe to merge; only P2 style/maintenance observations found.
No P0 or P1 bugs found. Both findings are P2: one is a style inconsistency (raw strings vs enum) and one is a defensive-code gap (silent empty list). Core create/poll/charts/examples flows are correctly implemented and well-tested.
nucleus/evaluation_v2.py (enum usage) and nucleus/init.py (list_evaluations_v2 silent fallback).
Important Files Changed
Sequence Diagram
sequenceDiagram participant User participant NucleusClient participant API User->>NucleusClient: create_evaluation_v2(model_run_id, ...) NucleusClient->>API: POST /modelRun/:id/evaluationsV2 API-->>NucleusClient: "{ evaluation_id }" NucleusClient->>API: GET /evaluationsV2/:id API-->>NucleusClient: EvaluationV2 payload NucleusClient-->>User: EvaluationV2 User->>NucleusClient: ev.wait_for_completion() loop Poll until terminal NucleusClient->>API: GET /evaluationsV2/:id API-->>NucleusClient: "{ status }" end NucleusClient-->>User: EvaluationV2 (succeeded) User->>NucleusClient: "ev.charts(iou_threshold=0.5)" NucleusClient->>API: "GET /evaluationsV2/:id/charts?iouThreshold=0.5" API-->>NucleusClient: EvaluationV2Charts JSON NucleusClient-->>User: EvaluationV2Charts User->>NucleusClient: "ev.examples(match_type=FP)" NucleusClient->>API: POST /evaluationsV2/:id/examples API-->>NucleusClient: EvaluationV2ExamplesPage JSON NucleusClient-->>User: EvaluationV2ExamplesPagePrompt To Fix All With AI
Reviews (4): Last reviewed commit: "fix p1" | Re-trigger Greptile