feat(sml): create an extended UserSetting integer ValueSelector#394
Open
RebeccaStevens wants to merge 1 commit into
Open
feat(sml): create an extended UserSetting integer ValueSelector#394RebeccaStevens wants to merge 1 commit into
RebeccaStevens wants to merge 1 commit into
Conversation
github-project-automation
Bot
moved this to 🆕 New
in Mod Loader (SML), Alpakit, ExampleMod, and Engine
The new `USMLIntValueSelector` extends the existing `UFGUserSetting_IntSelector` adding the ability for users to specify an enum to auto populate the values.
RebeccaStevens
force-pushed
the
enum-value-selector
branch
from
b4143a6 to
d6098b3
Compare
Member
|
Delayed till after 3.12 since Mircea wants to investigate an asset action enum autofill selector approach instead of the subclass approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
USMLIntValueSelectorextends the existingUFGUserSetting_IntSelectoradding the ability for users to specify an enum to auto populate the values.The new properties added only exist in the editor so there is minimal overhead and places for things to go wrong.
Known issue: If the enum is edited after being assigned to the selector, the values in the selector will not automatically update with the enum's new values.
Possible alternative: These changes could be put directly into the base
UFGUserSetting_IntSelectorclass instead of a new class that extends it.