Skip to content

DRAFT: Deps update novnc - #1596

Draft
sdelliot wants to merge 4 commits into
sandia-minimega:masterfrom
sdelliot:deps-update-novnc
Draft

DRAFT: Deps update novnc#1596
sdelliot wants to merge 4 commits into
sandia-minimega:masterfrom
sdelliot:deps-update-novnc

Conversation

@sdelliot

Copy link
Copy Markdown
Contributor

Description

Motivation and context

Testing

Checklist

  • This PR conforms to the process detailed in the Contributing Guide.
  • I have included no proprietary/sensitive information in my code.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have tested my code using the methods described above.
  • All GitHub Actions are passing.

Additional Notes

@sdelliot
sdelliot marked this pull request as draft February 20, 2026 21:11
@GhostofGoes

Copy link
Copy Markdown
Contributor

What's the status of this PR?

@GhostofGoes

Copy link
Copy Markdown
Contributor

Once this is out of draft please squash commits and update commit message and PR message to comply with conventional commits

@sdelliot

Copy link
Copy Markdown
Contributor Author

What's the status of this PR?

It was mostly tested, though there are a few minimega(isms) that might need to be adjusted. However, there was icon-related bug (novnc/noVNC#1956) that I was hoping to get pushed into a release before this was ready. That has now happened with https://github.com/novnc/noVNC/releases/tag/v1.7.0. Once I find some free time, I'll eventually pick this back up. However, I'm not exactly a web person, so if someone else wants to pick this up, I would be grateful! Aside from the easy part of vendoring the latest novnc release/dependencies, there are various paths that need to be updated, but these are fairly clear in: e384335 and a2608cf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants