fix pkg.installed on freebsd#68887
Open
network-shark wants to merge 1 commit intosaltstack:3006.xfrom
Open
Conversation
bdrx312
reviewed
Apr 6, 2026
Comment on lines
+920
to
+923
| elif __grains__["os"] == "FreeBSD" and pkgver: | ||
| cver = [k for k, v in new_pkgs.items() if v["version"] == pkgver] | ||
| _ok.append(pkgname) | ||
| continue |
Contributor
There was a problem hiding this comment.
On first glance this does not appear like it is the correct solution. I think _fulfills_version_string should be covering this.
Contributor
Author
There was a problem hiding this comment.
Thanks for the hint I will answer in the issue @bdrx312 . Hope to get some feedback thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes #68886
Previous Behavior
pkg.installed is was not idempotent on freebsd
Second run