Fix generated type for nullable custom scalars#36
Merged
ruudk merged 3 commits intoruudk:mainfrom Mar 1, 2026
Merged
Conversation
The test captures invalid `?` shorthand generation for nullable custom scalars that expand to multi-type unions, ensuring we require explicit `null|...` syntax.
Use explicit `null|...` syntax for nullable custom scalars that expand to multi-type unions so generated PHP types remain valid.
ruudk
approved these changes
Mar 1, 2026
Owner
ruudk
left a comment
There was a problem hiding this comment.
Good one, thanks!
Keep them coming!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nullable shorthand (
?Type) is only valid for a single type. When no mapping is defined for a custom scalar, it resolves to multiple native scalar types, so nullable output must be represented as an explicit union that includesnull.Schema
Before
After