Conversation
This impl doesn't feel very idiomatic and a direct invocation is clearer.
phip1611
commented
Jun 15, 2026
| #[must_use] | ||
| pub fn string_table(&self) -> Option<&[u8]> { | ||
| let shdr_table: SectionHeaderTable<NativeEndian> = self.into(); | ||
| let shdr_table = SectionHeaderTable::new(NativeEndian, self.class(), &self.sections); |
Member
Author
There was a problem hiding this comment.
FYI @an-owl - I think the From impl was not very idiomatic Rust. I decided to switch back to a normal constructor.
Nevertheless: thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This impl doesn't feel very idiomatic and a direct invocation is clearer.
Follow-up of #292.