Add a test for Mach-O #[link_section] API inherited from LLVM#155517
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 20, 2026
Merged
Add a test for Mach-O #[link_section] API inherited from LLVM#155517rust-bors[bot] merged 1 commit intorust-lang:mainfrom
#[link_section] API inherited from LLVM#155517rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
madsmtm
added
A-linkage
rustbot
added
A-run-make
This comment has been minimized.
This comment has been minimized.
madsmtm
force-pushed
the
test-macho-link-section-attrs
branch
from
7691a07 to
709530e
Compare
madsmtm
commented
Apr 19, 2026
madsmtm
force-pushed
the
test-macho-link-section-attrs
branch
from
709530e to
eae9611
Compare
This comment has been minimized.
This comment has been minimized.
madsmtm
force-pushed
the
test-macho-link-section-attrs
branch
from
eae9611 to
3695fef
Compare
bjorn3
approved these changes
Apr 20, 2026
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
…uwer Rollup of 11 pull requests Successful merges: - #154654 (Move `std::io::ErrorKind` to `core::io`) - #145270 (Fix an ICE observed with an explicit tail-call in a default trait method) - #154895 (borrowck: Apply `user_arg_index` nomenclature more broadly) - #155213 (resolve: Make sure visibilities of import declarations make sense) - #155346 (`single_use_lifetimes`: respect `anonymous_lifetime_in_impl_trait`) - #155517 (Add a test for Mach-O `#[link_section]` API inherited from LLVM) - #155549 (Remove some unnecessary lifetimes.) - #154248 (resolve : mark repr_simd as internal) - #154772 (slightly optimize the `non-camel-case-types` lint) - #155541 (Add `#[rust_analyzer::prefer_underscore_import]` to the traits in `rustc_type_ir::inherent`) - #155544 (bootstrap: Make "detected modifications" for download-rustc less verbose)
rust-timer
added a commit
that referenced
this pull request
Apr 20, 2026
Rollup merge of #155517 - madsmtm:test-macho-link-section-attrs, r=bjorn3 Add a test for Mach-O `#[link_section]` API inherited from LLVM The format of the `#[link_section]` attribute is under-documented, but on Mach-O, I think it's roughly the following BNF: ``` LinkSection -> Segment `,` Section (`,` (SectionType (`,` (SectionAttributes)?)?)?)? Segment -> <0 to 16 bytes> Section -> <0 to 16 bytes> SectionType -> `regular` | `zerofill` | `cstring_literals` | `4byte_literals` | `8byte_literals` | `literal_pointers` | `non_lazy_symbol_pointers` | `lazy_symbol_pointers` | `symbol_stubs` | `mod_init_funcs` | `mod_term_funcs` | `coalesced` | `interposing` | `16byte_literals` | `thread_local_regular` | `thread_local_zerofill` | `thread_local_variables` | `thread_local_variable_pointers` | `thread_local_init_function_pointers` SectionAttributes -> SectionAttribute (`+` SectionAttribute)* SectionAttribute -> `pure_instructions` | `no_toc` | `strip_static_syms` | `no_dead_strip` | `live_support`, `self_modifying_code` | `debug` ``` This PR adds a small test for a little part of this. Once #154429 is resolved, this should make it possible to test rust-lang/rustc_codegen_cranelift#1648 end-to-end. r? bjorn3
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Apr 21, 2026
…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#154654 (Move `std::io::ErrorKind` to `core::io`) - rust-lang/rust#145270 (Fix an ICE observed with an explicit tail-call in a default trait method) - rust-lang/rust#154895 (borrowck: Apply `user_arg_index` nomenclature more broadly) - rust-lang/rust#155213 (resolve: Make sure visibilities of import declarations make sense) - rust-lang/rust#155346 (`single_use_lifetimes`: respect `anonymous_lifetime_in_impl_trait`) - rust-lang/rust#155517 (Add a test for Mach-O `#[link_section]` API inherited from LLVM) - rust-lang/rust#155549 (Remove some unnecessary lifetimes.) - rust-lang/rust#154248 (resolve : mark repr_simd as internal) - rust-lang/rust#154772 (slightly optimize the `non-camel-case-types` lint) - rust-lang/rust#155541 (Add `#[rust_analyzer::prefer_underscore_import]` to the traits in `rustc_type_ir::inherent`) - rust-lang/rust#155544 (bootstrap: Make "detected modifications" for download-rustc less verbose)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format of the
#[link_section]attribute is under-documented, but on Mach-O, I think it's roughly the following BNF (I've opened rust-lang/reference#2236 to document it):This PR adds a small test for a little part of this.
Once #154429 is resolved, this should make it possible to test rust-lang/rustc_codegen_cranelift#1648 end-to-end.
r? bjorn3