fix: avoid race condition with parallel builds in shared cache#421
Merged
fix: avoid race condition with parallel builds in shared cache#421
Conversation
Put all generated wrappers, symlinks, and cmake toolchain files in a
per-exe subdirectory (`wrappers/{exe_hash}/`) so that parallel builds
driven by different binaries (e.g. multiple maturin instances in
separate temp venvs) never clobber each other.
- Hash `current_exe()` path to create isolated subdirectory per binary
- Move `zigcc`/`zigcxx`/`zigranlib` scripts, `ar`/`lib`/`dlltool`/`install_name_tool`
symlinks, and cmake toolchain files into it
- Extract `resolve_current_exe()` helper to deduplicate call sites
- Derive dlltool `PATH` from `zig_wrapper.ar` parent instead of recomputing
Fixes #318
messense
force-pushed
the
fix/parallel-build-race-condition
branch
from
b77c83a to
0428284
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put all generated wrappers, symlinks, and cmake toolchain files in a per-exe subdirectory (
wrappers/{exe_hash}/) so that parallel builds driven by different binaries (e.g. multiple maturin instances in separate temp venvs) never clobber each other.current_exe()path to create isolated subdirectory per binaryzigcc/zigcxx/zigranlibscripts,ar/lib/dlltool/install_name_toolsymlinks, and cmake toolchain files into itresolve_current_exe()helper to deduplicate call sitesPATHfromzig_wrapper.arparent instead of recomputingFixes #318
Closes #319