CI: Set and update weekly the stable toolchain version#264
Conversation
|
This is a direct copy of the file in |
| - name: Create Pull Request | ||
| uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e # v7.0.8 | ||
| with: | ||
| token: ${{ secrets.APOELSTRA_CREATE_PR_TOKEN }} |
There was a problem hiding this comment.
Is it intentional to copy the secret as in from rust-bitcoin, not using the one rust-bech32 (.github/workflows/cron-weekly-update-nightly.yml) named secrets.APOELSTRA_RUST_BITCOIN_ORG_CREATE_PR?
There was a problem hiding this comment.
Face palm. Fixed, thanks.
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| steps: |
There was a problem hiding this comment.
id-token: write is present in .github/workflows/cron-weekly-update-nightly.yml but not here. Just flagging. I suppose it's only necessary if this job connects and authenticates to external services.
There was a problem hiding this comment.
No clue, adding it in. cargo-cult-programming YOLO.
| eval "$(cargo rbmt toolchains --update-stable)" | ||
| echo "stable_version=$RBMT_STABLE" >> $GITHUB_ENV | ||
| - name: Create Pull Request | ||
| uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e # v7.0.8 |
| contents: write | ||
| pull-requests: write | ||
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 |
|
Thanks @satsfy. I'm just going to leave the commit hash comments with the |
Currently we are using `stable` for the stable toolchain. This is ok but it means we get whatever the Rust project pushes. Instead lets be explicit so we know exactly what version we get. Also add a cron job to update it weekly.
tcharding
force-pushed
the
push-xyzzoulrzvuv
branch
from
e08e424 to
69d4690
Compare
2 participants
Currently we are using
stablefor the stable toolchain. This is ok but it means we get whatever the Rust project pushes. Instead lets be explicit so we know exactly what version we get. Also add a cron job to update it weekly.