FIx env variable set with SERVER_CA_BUNDLE#803
Open
LucaPacioselli wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes handling of RUCIO_WEBUI_SERVER_CA_BUNDLE by switching the generated/runtime-consumed Node.js CA bundle environment variable from NODE_EXTRA_TLS_CERTS to NODE_EXTRA_CA_CERTS, aligning with the intended behavior described in issue #802 so the WebUI can trust a custom CA when connecting to the Rucio server.
Changes:
- Update env-generator template to emit
NODE_EXTRA_CA_CERTSinstead ofNODE_EXTRA_TLS_CERTS. - Update WebUI HTTP client code to read
NODE_EXTRA_CA_CERTSand adjust the related error message. - Update env-generator validation comment to reference the new env var name (note: stored feedback to clarify that the required input is still
SERVER_CA_BUNDLE).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/env-generator/src/templates/.env.liquid | Generates NODE_EXTRA_CA_CERTS from SERVER_CA_BUNDLE when SSL is enabled. |
| tools/env-generator/src/api/base.ts | Updates validation comment related to CA bundle requirements when TLS verification is enabled. |
| src/lib/sdk/http.ts | Reads CA bundle path from NODE_EXTRA_CA_CERTS and updates the corresponding error message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const requiredVariables: string[] = ["rucio_host", "rucio_auth_host", "hostname", "project_url", "vo_default", "vo_list", "nextauth_url"] | ||
|
|
||
| // check if NODE_TLS_REJECT_UNAUTHORIZED is set to 1, then NODE_EXTRA_TLS_CERTS should be set | ||
| // check if NODE_TLS_REJECT_UNAUTHORIZED is set to 1, then NODE_EXTRA_CA_CERTS should be set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the env variable set with
RUCIO_WEBUI_SERVER_CA_BUNDLEfromNODE_EXTRA_TLS_CERTStoNODE_EXTRA_CA_CERTS. This solves #802.