Skip to content

Add retry logic (10 retries, 30s delay) to all download commands in installation scripts#499

Merged
yihui merged 4 commits intomainfrom
copilot/add-download-retry-logic
Apr 5, 2026
Merged

Add retry logic (10 retries, 30s delay) to all download commands in installation scripts#499
yihui merged 4 commits intomainfrom
copilot/add-download-retry-logic

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 5, 2026

  • tools/install-base.sh: add download_file() function (curl/wget by availability), separate sedi alias from download logic, move downloads outside OS if/else, quote variables
  • tools/install-unx.sh: replace download alias with function, pick curl/wget by availability; keep TEXDIR OS-based separately
  • tools/install-bin-unix.sh: add download_file() function, replace OS-specific curl/wget if/else with single function call
  • tools/install-bin-windows.bat: simplify to irm ... | iex one-liner

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 5, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ yihui
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@yihui yihui marked this pull request as ready for review April 5, 2026 16:16
…nto functions, simplify bat

Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/f0fdfcff-e11d-498e-9d8e-f4ee26ded6c1

Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
Copilot AI requested a review from yihui April 5, 2026 16:27
Copilot finished work on behalf of yihui April 5, 2026 16:27
yihui added 2 commits April 5, 2026 11:37
Avoid duplicate downloads by performing download once before OS branch
@yihui yihui merged commit 1ae3ecc into main Apr 5, 2026
12 of 13 checks passed
@yihui yihui deleted the copilot/add-download-retry-logic branch April 5, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants