Conversation
Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/f4c6a244-9b14-4b53-bed3-3245fd7f67e7 Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
yihui
April 5, 2026 16:16
View session
|
|
…nto functions, simplify bat Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/f0fdfcff-e11d-498e-9d8e-f4ee26ded6c1 Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
Avoid duplicate downloads by performing download once before OS branch
yihui
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/install-base.sh: adddownload_file()function (curl/wget by availability), separatesedialias from download logic, move downloads outside OS if/else, quote variablestools/install-unx.sh: replacedownloadalias with function, pick curl/wget by availability; keep TEXDIR OS-based separatelytools/install-bin-unix.sh: adddownload_file()function, replace OS-specific curl/wget if/else with single function calltools/install-bin-windows.bat: simplify toirm ... | iexone-liner