Skip to content

Add "license-org" and "license-text" parameters - #298

Open
JasonShigit wants to merge 2 commits into
ros-infrastructure:masterfrom
JasonShigit:master
Open

Add "license-org" and "license-text" parameters#298
JasonShigit wants to merge 2 commits into
ros-infrastructure:masterfrom
JasonShigit:master

Conversation

@JasonShigit

Copy link
Copy Markdown

If "license-org" and license-text" are passing in command line, the default value will be overlayed in generated files.

@JasonShigit

Copy link
Copy Markdown
Author

@allenh1 Could you please review and comment?
Test pass with my meta-ros env.

If "license-org" and license-text" are passing in command line, the
default value will be overlayed in generated files.

Signed-off-by: Jason Shi <jaxonshi@qq.com>
@allenh1

allenh1 commented May 31, 2023

Copy link
Copy Markdown
Contributor

@JasonShigit sorry for the delay! I'm running CI on it now.

allenh1
allenh1 previously approved these changes May 31, 2023

@allenh1 allenh1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: Jason Shi <jaxonshi@qq.com>
@JasonShigit

Copy link
Copy Markdown
Author

Hi @allenh1
Thanks for help. The test failed and i updated one more change for test_ebuild.py. Is there any guidance for running tests locally?

@allenh1

allenh1 commented Jun 6, 2023

Copy link
Copy Markdown
Contributor

@JasonShigit it seems there are still a few errors to resolve.

The best way to run locally is to install all the requirements (see requirements.txt), and run pytest.

@robwoolley

Copy link
Copy Markdown
Contributor

Thanks for submitting this. Can you describe the use case for allowing superflore to generate recipes under a difference license?

Since the recipes are generated based on metadata, I am skeptical whether they can be copyrighted in the first place. Moreover the default copyright used for bitbake recipes is MIT and this patch would change the default to BSD.

If you can describe the reason for this change it will help me better understand why it is needed. I think before I could merge this in, I would need to run it by the OSRA.

@robwoolley

Copy link
Copy Markdown
Contributor

I raised the questions in our ROS Infra meeting. The general consensus is that this change should be put on hold for now. They reached out to the ROS PMC for clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants