add openeuler support - #919
Conversation
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
Overall we're happy to add support for additional OSs. However as I haven't heard of this one. Can you please provide a little bit more context as to the user base and the package management system and database. In particular I see that it uses the DNF and YUM installers. Does it track/follow/use one of the other package databases or does it have it's own package database for example we have a lot of rhel clones that don't need separate database entries? This will be important that we have a set of rules .
|
openEuler (formerly EulerOS) is a Red-Hat-like Linux distribution. It is the successor of Huawei's EulerOS. openEuler is an open source project incubated and operated by the OpenAtom Foundation. It use DNF as package-management, but no base on other distribution, many package name are different from rhel, like RHEL named "libzstd-devel",but openEuler named "zstd-dev" have some linux Commercial Editions base on it, see https://www.openeuler.org/en/download/commercial-release/ official website: https://www.openeuler.org/en/ |
|
@tfoote Could you please review and accept this PR? As @Z572 has already elaborated on the openEuler OS context, and the rospkg side has merged the relevant PR. Now the rosdistro part is pending your review, as noted in the comment of rosdistro/pull/36933 |
|
Sorry I'm having trouble submitting the review comments formally. Thanks for the extra info and looking at 24.09 it looks like there's been a big push since this was submitted. Reviewing the implementation, can you please register it in alphabetical order and have the definition in the same order for easier readability maintenance in the future. |
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
I can do the proper review now with line comments.
| register_fedora(context) | ||
| register_rhel(context) | ||
|
|
||
| register_openeuler(context) |
There was a problem hiding this comment.
Please move this up to be in alphabetical order.
| register_rhel_clone(context, OS_ROCKY) | ||
|
|
||
|
|
||
| def register_openeuler(context): |
There was a problem hiding this comment.
Please move this down to be in alphabetical order.
|
Hi @Z572, @tfoote and the @ros-infrastructure maintenance team, First, thank you for the feedback and the detailed review on this PR.
The new PR supersedes this one. Thank you @Z572 for the great initial work to get this started! |
3 participants
require ros-infrastructure/rospkg#260
ros/rosdistro#36933