Skip to content

Optionally supress sudo rosdep update warning with flag - #915

Open
ijnek wants to merge 1 commit into
ros-infrastructure:masterfrom
ijnek:ijnek-supress-sudo-warning-with-flag
Open

Optionally supress sudo rosdep update warning with flag#915
ijnek wants to merge 1 commit into
ros-infrastructure:masterfrom
ijnek:ijnek-supress-sudo-warning-with-flag

Conversation

@ijnek

@ijnek ijnek commented Feb 23, 2023

Copy link
Copy Markdown
Member

This adds a flag to simply supress the warning if a user wants to.
It seems better than telling everyone to ignore the warning if using docker (which is often root).

Resolves: #473

Signed-off-by: ijnek <kenjibrameld@gmail.com>
@ijnek

ijnek commented Feb 23, 2023

Copy link
Copy Markdown
Member Author

Mac OS CI failing due to #912

@codecov-commenter

codecov-commenter commented Mar 14, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.84%. Comparing base (b6ad189) to head (7150bba).
⚠️ Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
src/rosdep2/main.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #915   +/-   ##
=======================================
  Coverage   74.83%   74.84%           
=======================================
  Files          44       44           
  Lines        3362     3363    +1     
=======================================
+ Hits         2516     2517    +1     
  Misses        846      846           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sudo and rosdep

2 participants