[6.40] Use different output filenames in tests pdftitle.cxx and pdfurl.cxx#22729
Merged
guitargeek merged 1 commit intoJun 29, 2026
Merged
Conversation
This avoids failures when one test overwrites the other's output:
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TPad
[ RUN ] TPad.PDFUrl
ROOT::TestSupport::ForbidDiagnostics::handler(): Diagnostic in 'TCanvas::Print':
pdf file output.pdf has been created
ROOT::TestSupport::ForbidDiagnostics::handler(): Diagnostic in 'TCanvas::Print':
Current canvas added to pdf file output.pdf
ROOT::TestSupport::ForbidDiagnostics::handler(): Diagnostic in 'TCanvas::Print':
Current canvas added to pdf file output.pdf
ROOT::TestSupport::ForbidDiagnostics::handler(): Diagnostic in 'TCanvas::Print':
pdf file output.pdf has been closed
/builddir/build/BUILD/root-6.40.02/graf2d/gpad/test/pdfurl.cxx:33: Failure
Expected equality of these values:
statCode
Which is: 1
0
PDF file was not created.
[ FAILED ] TPad.PDFUrl (373 ms)
[----------] 1 test from TPad (373 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (374 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] TPad.PDFUrl
1 FAILED TEST
(cherry picked from commit 55f5a1b)
2 tasks
Test Results 21 files 21 suites 3d 4h 27m 5s ⏱️ Results for commit 70084ba. |
guitargeek
merged commit d69ffcb
into
root-project:v6-40-00-patches
35 of 37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22722, requested by @guitargeek. For your information @ellert