Test fixes#22724
Open
ellert wants to merge 3 commits into
Open
Conversation
Do not fail test if version 3 is returned.
Do not assume it is 2 * sizeof(double), which is not true on 32 bit.
ellert
requested review from
dpiparo,
hageboeck,
jblomer,
pcanal,
silverweed and
vepadulano
as code owners
jblomer
approved these changes
Jun 28, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Looks good to me. The formatting error should be fixed.
| RDFHist() | ||
| { | ||
| fDiag.optionalDiag(kWarning, "", "Filling RHist is experimental", /*matchFullMessage=*/false); | ||
| fDiag.optionalDiag(kWarning, "cling", "expected alignment (8 bytes) exceeds the actual alignment (4 bytes) [-Watomic-alignment]", false); |
Contributor
There was a problem hiding this comment.
Perhaps make conditional to 32bit platforms. @hahnjo FYI
Test Results 23 files 23 suites 3d 15h 53m 30s ⏱️ For more details on these failures, see this check. Results for commit 07cbb05. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
The old TUUID constructor can create either version 1 or 3
Do not fail test if version 3 is returned.
Do not fail test on 32 bit due to mis-aligned atomic
Compare size to the size of the struct
Do not assume it is 2 * sizeof(double), which is not true on 32 bit.
Checklist:
This PR fixes #