fix(flutter): prevent ConcurrentModificationError in SignalsMixin#436
Merged
rodydavis merged 1 commit intorodydavis:mainfrom Dec 19, 2025
Merged
Conversation
HashMap.values returns a lazy Iterable. During iteration, accessing s.target.value can trigger bindSignal() which calls _watch(), mutating _signals while the iterator is active. Similarly, clearSignalsAndEffects() iterates lazily over _signals and _effects while dispose()/cleanup() calls can mutate these collections. Fix: Convert lazy iterables to List snapshots before iteration. Fixes rodydavis#431
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #431 -
ConcurrentModificationErrorwhen usingSignalsMixin.Problem
HashMap.valuesreturns a lazyIterable, not a snapshot. During iteration in_setup(), accessings.target.valuecan triggerbindSignal()→_watch(), which mutates_signalswhile the iterator is active.Similarly,
clearSignalsAndEffects()iterates lazily over_signalsand_effectswhiledispose()/cleanup calls can mutate these collections.Solution
Convert lazy iterables to
Listsnapshots before iteration:Changes
_setup(): Snapshot_signals.valuesbefore iteratingclearSignalsAndEffects(): Snapshot both_signals.valuesand_effectsbefore iteratingMinimal, surgical fix with no behavioral changes.