Install rpms through fakeroot#6
Open
manuelnaranjo wants to merge 4 commits intormohr:masterfrom
Open
Conversation
We need newer rules_docker if we want to run the tests against upstream Bazel
rpms used for tests are archived, updating the URLs
rpms will have all of it's filed owned by root:root, so let's test for that
Decompressing rpms through fakeroot to preserve file ownership and permissions properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When uncompressing cpio files it's best to keep original permissions, for this to be possible we need to fake the system to make it believe we're running as root, because doing sudo or su would be insane and of course out of the question, let's instead use fakeroot which was created for packing software in particular.
Also had to bump some dependencies like rules_docker so the tests would run against newer versions of bazel, lastly the rpms referenced by the tests are no longer available on the repos but archived so pointing to those instead.