fix(rivetkit): isolate engine envoys and propagate startup failures#4643
Draft
NathanFlurry wants to merge 1 commit intotest/remove-wasm-sqlite-fixturesfrom
Draft
fix(rivetkit): isolate engine envoys and propagate startup failures#4643NathanFlurry wants to merge 1 commit intotest/remove-wasm-sqlite-fixturesfrom
NathanFlurry wants to merge 1 commit intotest/remove-wasm-sqlite-fixturesfrom
Conversation
This was referenced Apr 13, 2026
Member
Author
This was referenced Apr 13, 2026
PR Review: fix(rivetkit): isolate engine envoys and propagate startup failuresThis is a focused, well-scoped fix addressing two related issues: envoy singleton reuse across drivers and silent startup failure swallowing. What this PR does
IssuesMedium: start_envoy panics on startup failure instead of returning ResultPer CLAUDE.md conventions, failable functions should return anyhow::Result and use .context() rather than .expect(). A panic here is not recoverable and bypasses the error propagation the rest of this PR correctly establishes. Suggested fix: change the return type to anyhow::Result and replace .expect() with .context("envoy failed to start")?. Minor: Prefer .context() over anyhow::anyhow!()CLAUDE.md states: prefer .context() over the anyhow! macro. The .map_err call in handle.rs can be replaced with .context("envoy stopped before startup completed")?. Positive observations
|
ada1fe0 to
dbb2ed4
Compare
8786de2 to
b2d071c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: