fix(rivetkit-swift): avoid double percent-encoding paths in URLUtils#4609
Open
Makisuo wants to merge 2 commits intorivet-dev:mainfrom
Open
fix(rivetkit-swift): avoid double percent-encoding paths in URLUtils#4609Makisuo wants to merge 2 commits intorivet-dev:mainfrom
Makisuo wants to merge 2 commits intorivet-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
combineUrlPathbuildsfullPathfrom already-encoded segments (buildActorGatewayUrlrunsaddingPercentEncoding(...)on the actor ID, and the action helpers inRemoteManagerdo the same on path-injected IDs/keys), then assigns it toURLComponents.path, which runs another encoding pass and turns%3Ainto%253A.This is invisible for backends whose actor IDs are URL-safe (file-system driver hex hash, engine UUIDs, etc.), so it slipped through. But
@rivetkit/cloudflare-workersformats actor IDs as${durableObjectId}:${generation}, so:→%3A→%253A. After the round-trip the worker decodes one layer andparseActorIdthrowsInvalid actor ID format: ...e3704%3A0, the WebSocket handshake fails, and the SwiftUI client enters a reconnect loop.Repro:
wrangler deva@rivetkit/cloudflare-workersregistry exposing any actor.http://127.0.0.1:8787/api/rivetand trigger an action.PUT /actorssucceeds (no encoded segment in the path), then/gateway/{actorId}/connect500s withInvalid actor ID format. Patched build connects normally and events flow.The plain API paths (
/metadata,/actors,?namespace=...) have nothing to re-encode, so they're unaffected by the switch topercentEncodedPath. I didn't add a unit test becauseURLUtilsis internal and the existing tests run against aTestServer— happy to add@testablecoverage if you'd prefer.